upgrade to pytorch 1.1.0a0+ec8b1c9 #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainwoodman
reviewed
Feb 15, 2019
|
Now it builds libtorch as well. |
rainwoodman
reviewed
Feb 15, 2019
| cd build_libtorch | ||
| BUILD_TORCH=ON ONNX_NAMESPACE=onnx_torch bash ../tools/build_pytorch_libs.sh --use-nnpack caffe2 | ||
| } && { | ||
| echo -e "\nSuccessfully built libtorch at `dirname $PWD`/torch/lib/tmp_install\n" |
There was a problem hiding this comment.
Hmm. but why not install libtorch to the proper directory? Is it because there is a conflict?
There was a problem hiding this comment.
It seems that in fact it's also built in torch/, and they've removed /torch/lib/tmp_install in a later commit. I just tried the latest version, and pytorch itself was built successfully. But they changed the way to build libtorch, and there's a bug that I don't know how to fix. I'm gonna ask them before updating this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.