New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-1011 UGC Form Submit Button #11613
Conversation
…gh into WSTEAM1-1011-UGC-submit-button
Also (perhaps a question for @amoore108 or @andrewscfc), do we need to do anything about disabling the Submit button functionality when viewing the UGC Page on Storybook? |
Not really sure tbh. The UGC API is only accessible on authorised domains, so Storybook will always fail. Don't think its a huge problem as it won't do anything if someone tries to make a POST request from it. |
Testing Firefox I get the same focus indicator issue @karinathomasbbc had. Chrome seems fine though 🤔 |
Oops forgot to mention - yes, this was on Firefox, using the Storybook Permalink. |
okay this should be fixed now, not entirely sure why the global styling for the focus indicator wasnt working for firefox, but if i just paste it explicitly into the css file it works 🤷 weird |
Not sure if relevant but I remember Firefox being a bit odd sometimes with the focus indicator. |
figured it out, firefox has default styling for elements of type 'submit' that needed to be overwritten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fab - thanks for making those changes :)
Resolves JIRA WSTEAM1-1011
Overall changes
Adds styling for submit button
Code changes
Service neutral core
to paletteTesting
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines