WSTEAM1-969: Add Checkbox #11610
WSTEAM1-969: Add Checkbox #11610
Conversation
…TEAM1-969-CHECKBOX
| checkboxLabel: ({ spacings }: Theme) => | ||
| css({ | ||
| flex: 'auto', | ||
| marginLeft: `${spacings.DOUBLE}rem`, |
There was a problem hiding this comment.
We'll need marginInlineStart to allow for RTL languages to have the correct spacing
There was a problem hiding this comment.
Looks good - I looked through the AACs and compared to the Storybook UGC page, and tested with VoiceOver on Safari on mac.
One thing I noticed in both the AAC's and the Screen reader UX we refer to the Checkbox as required. However, the checkbox we have on the example form the Storybook doesn't appear to be required.
Do we know how many of the default form structures have required checkboxes? If there are some maybe we should add one required and one non-required checkbox to storybook so we can test both in the swarm. If there are none, then perhaps we should update the AAC's and Screen reader UX?
|
I think this may get resolved in the upcoming ARIA ticket WSTEAM1-998 |
Resolves JIRA WSTEAM1-969
Overall changes
Adds Checkbox styling:
Code changes