WSTEAM1-1005: Gujarati Telugu font updates #11599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const MALLANA_FONTS_DIR = | ||
| 'https://ws-downloads.files.bbci.co.uk/fonts/Mallanna/v1.0.4/'; | ||
| const NOTO_SANS_TELUGU_FONTS_DIR = | ||
| 'https://ws-downloads.files.bbci.co.uk/fonts/NotoSansTelugu/v1.00/'; |
There was a problem hiding this comment.
Not live yet, hence 'do not merge' label
| 'https://ws-downloads.files.bbci.co.uk/fonts/NotoSansTelugu/v1.00/'; | ||
|
|
||
| const NOTO_SANS_GUJARATI_FONTS_DIR = | ||
| 'https://ws-downloads.files.bbci.co.uk/fonts/NotoSansGujarati/v1.00/'; |
There was a problem hiding this comment.
Not live yet, hence 'do not merge' label
There was a problem hiding this comment.
is there a PR for the font server repo or is that already up there/has it been merged?
There was a problem hiding this comment.
Yep it's linked in this ticket: https://jira.dev.bbc.co.uk/browse/WSTEAM1-1003
It has been merged but I'm still working through the steps to deploy
emilysaffron
approved these changes
May 9, 2024
pvaliani
approved these changes
May 9, 2024
|
Re-running the E2E's on this but Cypress just got patched this morning: And i'm not sure if the failure is related, just FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WSTEAM1-1005 - Simorgh Changes, subtask of WSTEAM1-900 - Updated fonts for two Indian services
Overall changes
Updates default fonts for two services
Telugu from 'Mallanna' to 'Noto Sans Telugu'
Gujarati from 'Mukta Vaani' to 'Noto Sans Gujarati'
Code changes
STORYBOOK
THEME PROVIDER
PSAMMEAD
Testing
I think UX can test this on preview. Otherwise we can put a change freeze in and test on test.
Helpful Links
Dropbox paper instructions
Coding Standards
Repository use guidelines