Spikes/korean downloads #11594
Draft
Spikes/korean downloads #11594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
amoore108
reviewed
May 7, 2024
| @@ -62,7 +62,7 @@ | |||
| "test:e2e": "yarn stop && yarn build && run-p --race start cypress", | |||
| "test:e2e:interactive": "yarn stop && yarn build && run-p --race start cypress:interactive", | |||
| "test:lint": "eslint --ext .js,jsx,json,ts,tsx ./src ./data ./cypress ./.storybook ./webpack**", | |||
| "test:lint:fix": "eslint --fix --ext .js,jsx,json,ts,tsx ./src ./data ./cypress ./.storybook ./webpack**", | |||
| "test:lint:fix": "eslint --fix --ext .js,jsx,json,ts,tsx ./src ./data ./ws-nextjs-app/pages ./cypress ./.storybook ./webpack**", | |||
ws-nextjs-app/pages/[service]/downloads/downloadsPageLayout.tsx
Outdated
Show resolved
Hide resolved
amoore108
reviewed
May 8, 2024
Comment on lines
19
to
24
| translations: { | ||
| downloads?: { | ||
| instructions = 'You can download and view today’s news.', | ||
| title = 'File Download', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| translations: { | |
| downloads?: { | |
| instructions = 'You can download and view today’s news.', | |
| title = 'File Download', | |
| }, | |
| }, | |
| translations: { | |
| downloads: { | |
| instructions = 'You can download and view today’s news.', | |
| title = 'File Download', | |
| } = {}, | |
| }, |
amoore108
reviewed
May 8, 2024
| import styles from './styles'; | ||
| import { PageProps } from './types'; | ||
|
|
||
| const downloadsPageLayout = ({ service, pageData }: PageProps) => { |
There was a problem hiding this comment.
This will need to be DownloadsPageLayout (capital D) to make it a valid React component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poc