Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react monorepo #11578

Merged
merged 3 commits into from May 14, 2024
Merged

Update react monorepo #11578

merged 3 commits into from May 14, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 30, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/react (source) 18.2.79 -> 18.3.2 age adoption passing confidence
@types/react-dom (source) 18.2.25 -> 18.3.0 age adoption passing confidence
react (source) 18.2.0 -> 18.3.1 age adoption passing confidence
react-dom (source) 18.2.0 -> 18.3.1 age adoption passing confidence
react-test-renderer (source) 18.2.0 -> 18.3.1 age adoption passing confidence

Release Notes

facebook/react (react)

v18.3.1

Compare Source

v18.3.0

Compare Source

facebook/react (react-dom)

v18.3.1

Compare Source

v18.3.0

Compare Source

facebook/react (react-test-renderer)

v18.3.1

Compare Source

v18.3.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@amoore108
Copy link
Contributor

amoore108 commented Apr 30, 2024

React 19 will be dropping support for defaultProps, so the unit tests are failing due to this pre-emptive warning:
Support for defaultProps will be removed from function components in a future major release

We can suppress this warning globally for now to get it passing, but we should consider removing defaultProps and prop-types in general for React 19.

https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops

@renovate renovate bot force-pushed the renovate/react-monorepo branch 14 times, most recently from 59273b5 to bb6dc98 Compare May 7, 2024 09:33
@renovate renovate bot force-pushed the renovate/react-monorepo branch 6 times, most recently from e430c6c to 57b8603 Compare May 8, 2024 11:36
@karinathomasbbc
Copy link
Collaborator

React 19 will be dropping support for defaultProps, so the unit tests are failing due to this pre-emptive warning: Support for defaultProps will be removed from function components in a future major release

We can suppress this warning globally for now to get it passing, but we should consider removing defaultProps and prop-types in general for React 19.

https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops

I think I would rather remove the defaultProps rather than suppress the error - otherwise we'll never do it 😅 - so part of the work to get the tests passing on this PR is to fix up the issues (and then test it on Preview to make sure all is OK)

@amoore108
Copy link
Contributor

I think I would rather remove the defaultProps rather than suppress the error - otherwise we'll never do it 😅 - so part of the work to get the tests passing on this PR is to fix up the issues (and then test it on Preview to make sure all is OK)

Yea there are no functional changes to this release, its just those elevated warning messages to get people ready for React 19.

@renovate renovate bot force-pushed the renovate/react-monorepo branch 5 times, most recently from 7521c36 to 8064ed1 Compare May 9, 2024 13:44
@amoore108
Copy link
Contributor

I think I would rather remove the defaultProps rather than suppress the error - otherwise we'll never do it 😅 - so part of the work to get the tests passing on this PR is to fix up the issues (and then test it on Preview to make sure all is OK)

Created #11612 as a first try at this. It removes a lot of stuff. The defaultProp is the most important removal, as that does set default values which I've tried to replicate with using the ES6 default value syntax for prop arguments. propTypes is less important as its just a type checking, rather than affecting any logic directly.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from 8064ed1 to 80145a3 Compare May 10, 2024 07:24
@renovate renovate bot force-pushed the renovate/react-monorepo branch 5 times, most recently from 3c14e72 to 9666c75 Compare May 11, 2024 10:45
@renovate renovate bot force-pushed the renovate/react-monorepo branch from 9666c75 to ac1b1a5 Compare May 13, 2024 08:01
@amoore108 amoore108 merged commit 01d279c into latest May 14, 2024
11 checks passed
@amoore108 amoore108 deleted the renovate/react-monorepo branch May 14, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants