Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency undici to v6.16.1 #11482

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 8, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
undici (source) 6.11.1 -> 6.16.1 age adoption passing confidence

Release Notes

nodejs/undici (undici)

v6.16.1

Compare Source

v6.16.0

Compare Source

What's Changed

New Contributors

Full Changelog: nodejs/undici@v6.15.0...v6.16.0

v6.15.0

Compare Source

What's Changed

New Contributors

Full Changelog: nodejs/undici@v6.14.1...v6.15.0

v6.14.1

Compare Source

What's Changed

Full Changelog: nodejs/undici@v6.14.0...v6.14.1

v6.14.0

Compare Source

What's Changed

New Contributors

Full Changelog: nodejs/undici@v6.13.0...v6.14.0

v6.13.0

Compare Source

What's Changed

New Contributors

Full Changelog: nodejs/undici@v6.12.0...v6.13.0

v6.12.0

Compare Source

What's Changed

New Contributors

Full Changelog: nodejs/undici@v6.11.1...v6.12.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/undici-6.x branch 6 times, most recently from 19eb9a2 to 50eccd4 Compare April 9, 2024 10:18
@renovate renovate bot force-pushed the renovate/undici-6.x branch 23 times, most recently from 6fe2d15 to f4adcdb Compare April 12, 2024 08:03
@renovate renovate bot force-pushed the renovate/undici-6.x branch 8 times, most recently from c60b774 to 4286d23 Compare May 7, 2024 16:09
@renovate renovate bot changed the title Update dependency undici to v6.15.0 Update dependency undici to v6.16.0 May 7, 2024
@karinathomasbbc
Copy link
Collaborator

ATI seems to be logging okay on opera mini:

Actually undici seems to be used in the nextjs app, however it looks like opera mini is surpressing console logging I've tried to inject? The preview env when visiting from Chrome on mac seems to log the fetch output of ATI, but looking at server:console in opera mini I get no output

I get this when I visit https://www.bbc.com/pidgin on Opera Mini on my Samsung Flip 😭

Screenshot_20240507_180040_Opera Mini

@karinathomasbbc
Copy link
Collaborator

I get this when I visit https://www.bbc.com/pidgin on Opera Mini on my Samsung Flip 😭

Same for the preview environment - albeit it doesn't have this PR deployed at the moment, but I would expect to see something else instead of ECMAScript errors (at the very least, the error itself!)

@karinathomasbbc
Copy link
Collaborator

karinathomasbbc commented May 7, 2024

ATI seems to be logging okay on opera mini:

Was this via the Opera mini emulator, or a phone?

@HarveyPeachey
Copy link
Contributor

HarveyPeachey commented May 8, 2024

ATI seems to be logging okay on opera mini:

Was this via the Opera mini emulator, or a phone?

This was with my Oppo android phone, I also combined debug fetch code I created here to get console debugging output. I think this dependency is only running on NextJS powered pages, as the lockfile file only references the NextJS app using it, so any page served by the express serve should be business as usual. However, when I visited a live page powered by next, I wasn't getting any console output both with this dep update, and on the latest branch

@amoore108
Copy link
Contributor

I'm pretty comfortable with just merging this as as @HarveyPeachey says its just used in the Next.js app.

It'll require much more thorough testing once we do the node-fetch removal and use undici across both apps.

@renovate renovate bot force-pushed the renovate/undici-6.x branch 9 times, most recently from a8f1e10 to ecf9aea Compare May 10, 2024 10:17
@renovate renovate bot changed the title Update dependency undici to v6.16.0 Update dependency undici to v6.16.1 May 10, 2024
@renovate renovate bot force-pushed the renovate/undici-6.x branch 2 times, most recently from 6177400 to 9038a60 Compare May 10, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants