WSTEAM1-705: Link to post using post asset ID as hashparam (Spike) #11418
+76
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isabella-Mitchell
changed the title
| }; | ||
|
|
||
| const LivePage = ({ pageData }: ComponentProps) => { | ||
| const FakeKeyPointLinks = () => { |
There was a problem hiding this comment.
Remove this 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA SPIKE [WSTEAM1-705]
Overall changes
Following discussions of how suitable the PS approach (using a ‘Back to Latest’ link) is for WS - I wanted to make a version which did not use this.
Instead the post asset ID is used as the hash param to take the user’s focus to the shared post.
(This PR uses server side rendering and is a cleaner version of a previous PR: #11260. It utilises the same BFF PR as before).
Here is an example of a shared link:
Local: http://localhost:7081/pidgin/live/c07zr0zwjnnt?renderer_env=test&post=asset%3A3b133574-88dc-41e0-9d90-0d3e847adba3#asset:3b133574-88dc-41e0-9d90-0d3e847adba3
Live equivalent: https://bbc.com/pidgin/live/c07zr0zwjnnt?post=asset%3A3b133574-88dc-41e0-9d90-0d3e847adba3#asset:3b133574-88dc-41e0-9d90-0d3e847adba3
The link is structured as Domain + post asset query (to take to the correct page) + post asset hash param (to take to the correct post)
On local there is a renderer env query is also required.
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines