[7.2.0] Apply repo mapping to cc_shared_library's exports_filter
#22328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for `exports_filter` to match any external repositories with Bzlmod enabled. `native.package_relative_label` is used to convert the user-specified filter strings, which are always valid labels, to canonical label literals that are then passed to the actual `cc_shared_library` rule. Fixes #21872 Closes #21622. PiperOrigin-RevId: 632624776 Change-Id: I2f80563d8c434b2726f4facb0551b316b2cd2e1c
github-actions
bot
added
the
awaiting-review
keertk
approved these changes
May 11, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for
exports_filterto match any external repositories with Bzlmod enabled.native.package_relative_labelis used to convert the user-specified filter strings, which are always valid labels, to canonical label literals that are then passed to the actualcc_shared_libraryrule.Fixes #21872
Closes #21622.
PiperOrigin-RevId: 632624776
Change-Id: I2f80563d8c434b2726f4facb0551b316b2cd2e1c