Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start time to execlog Spawn #22281

Closed
wants to merge 2 commits into from
Closed

Add start time to execlog Spawn #22281

wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented May 7, 2024 •
edited

RELNOTES: The compact and full execution logs now contain start times for spawns (if available).

@fmeum fmeum requested a review from tjgq May 7, 2024 17:00
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 7, 2024
@iancha1992 iancha1992 added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label May 7, 2024
@sluongng sluongng mentioned this pull request May 8, 2024
Closed
tjgq
tjgq requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@tjgq tjgq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test (//src/test/java/com/google/devtools/build/lib/exec/SpawnLogContextTestBase.java)?

@fmeum
Copy link
Collaborator Author

fmeum commented May 8, 2024

Added a test.

@fmeum fmeum requested a review from tjgq May 8, 2024 11:40
@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 8, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented May 8, 2024

@bazel-io fork 7.2.0

@bazel-io bazel-io mentioned this pull request May 8, 2024
Closed
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 13, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request May 13, 2024
@fmeum @bazel-io
Add start time to execlog Spawn
64507c6 
RELNOTES: The compact and full execution logs now contain start times for spawns (if available).

Closes bazelbuild#22281.

PiperOrigin-RevId: 633108842
Change-Id: I3b7fbf8559b7583dcfe5ed0ff5eaf736de4f1f8d
@bazel-io bazel-io mentioned this pull request May 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 13, 2024
@bazel-io @fmeum
[7.2.0] Add start time to execlog Spawn (#22341)
8243e5a 
RELNOTES: The compact and full execution logs now contain start times
for spawns (if available).

Closes #22281.

PiperOrigin-RevId: 633108842
Change-Id: I3b7fbf8559b7583dcfe5ed0ff5eaf736de4f1f8d

Commit
73b0faf

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@fmeum fmeum deleted the execution-log-start-time branch May 14, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq tjgq approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmeum @tjgq @iancha1992