Fix issues with path mapping in map_each
functions
#22227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues with path mapping applied to
map_each
functions:File
s mapped at execution time. This commit introduces a specialPathMapper
instance for fingerprinting, see the long comment onPathMappers.FOR_FINGERPRINTING
. It includes a number of tests to verify that neither too much nor too little is mapped during action key computation.StarlarkSemantics
of a thread used to evaluatemap_each
callbacks is not modified.These changes require splitting
PathMappers
out ofanalysis_cluster
and also makeStrippingPathMapper
a subclass ofPathMapper
instead of using an anonymous one.