Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix octoprint timestamp #693

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

the-kaustubh
Copy link

@the-kaustubh the-kaustubh commented Aug 28, 2023

Description

The octoprint services in 'text' mode consumes the octoprint api to show print-job progress. The code converting data to 'mm:ss' format assumed timestamp will be given by the API, instead time in seconds is given. This caused octoprint to show wrong info, I have updated the service to correctly convert from seconds and show progress along with 'Time Left'.
Edit:
Referred following documentation for my fix:
https://docs.octoprint.org/en/master/api/datamodel.html#sec-api-datamodel-jobs-job

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit 2d15e83
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/64ece2bd53be210007d43255
😎 Deploy Preview https://deploy-preview-693--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@royto
Copy link
Contributor

royto commented Aug 31, 2023

looks good to me.

Note for future myself: do not review on mobile app late 😄

@the-kaustubh
Copy link
Author

@royto I guess you can approve the PR if the changes look ok?

@royto
Copy link
Contributor

royto commented Sep 1, 2023

I have approved but I'm not maintainer ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants