Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: Info popup component #655

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Wiiolis
Copy link

@Wiiolis Wiiolis commented Jun 2, 2023

Description

New feature that's allowing to add info button on cards with popup and description.
Fixed #issue
It extends Generic component.
Data format is:

item: {
  info: {
    header: "fancy header",
    content: "fancier content"
  }
}

I'm pretty new to all this forking stuff so if you don't like it that's fine. I just wanted to try it and maybe contribute with something useful :D

Preview images:
Screenshot 2023-06-02 at 15 37 03
Screenshot 2023-06-02 at 15 40 18

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit f53348f
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/6479fdf10f3c6000087eb629
😎 Deploy Preview https://deploy-preview-655--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant