Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting no-cors in ping service #651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kmjayadeep
Copy link

Description

Currently Ping custom service does not work if the service is hosted under a different domain and no Access-Control-Allow-Origin header is set on the api response. This PR fixes this issue by allowing to make requests with mode: no-cors in fetch api.

More info about the mode field can be found here

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit 3750920
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/646af9eec8484d0008762401
😎 Deploy Preview https://deploy-preview-651--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Jayadeep KM <kmjayadeep@gmail.com>
@DanielBaulig
Copy link

@bastienwirtz Any chance we can get this merged? This would give us a great alternative to setting up proxy servers for fixing CORS related ping issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants