Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for testing dependencies; travis #976

Open
wants to merge 6 commits into
base: develop-3.0
Choose a base branch
from

Conversation

llelf
Copy link
Contributor

@llelf llelf commented May 13, 2019

Not all tests pass. At least some of them because they are being run as a different profile¹. Ideas?

¹)

riak/Makefile

Line 59 in 8dcae40

echo '{profiles, [{deptest, [{base_dir, "../../.."}]}]}.' >> $(TMP_CONFIG) && \

@ThomasArts
Copy link
Contributor

The problem is not so much the profile as that some tests have hard coded paths. With the profile deptests the idea was to test each riak dependency separately. That works reasonable, as long as the paths are not wrong.

It seems really easy to add travis. Possibly we should add travis just for ./rebar3 eunit to run the 5 unit tests (they pass). In the meanwhile, I work on getting the really failing tests and the tests that have wrong path to be fixed. After that, we add make test to this travis script. Agree?

@llelf
Copy link
Contributor Author

llelf commented May 14, 2019

It seems really easy to add travis

Yes, not having to build a custom OTP in travis helps tremendously ;-)

The problem is not so much the profile as that some tests have hard coded paths

Custom profile doesn’t help either. E. g. some dependencies have
{erl_opts, [nowarn_export_all]} for their test profile.

I changed it too only run riak’s eunit tests for now.

@llelf
Copy link
Contributor Author

llelf commented May 20, 2019

Made more of dependencies tests work.

@llelf llelf changed the title Travis Fixes for testing dependencies; travis May 21, 2019
@llelf
Copy link
Contributor Author

llelf commented May 21, 2019

These deps are failing (https://travis-ci.org/llelf/riak/builds/535391932)

a b
cuttlefish
eper basho/riak_kv#1689 ?
hyper
ibrowse
kv_index_tictactree
lager
mochiweb
syslog
webmachine
yokozuna basho/yokozuna#757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants