Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CI #1072

wants to merge 1 commit into from

Conversation

afcapel
Copy link
Contributor

@afcapel afcapel commented Jul 20, 2023

Test against the latest browser and OS versions. Android 9 is EOLed, test instead against Android 11 which is the oldest version still receiving updates.

Also test the latest Safari version.

@afcapel afcapel force-pushed the update-browser-versions branch 3 times, most recently from d1b89b8 to e1b2fda Compare July 20, 2023 12:44
@afcapel afcapel changed the title Update browser versions Fix CI Jul 20, 2023
@afcapel afcapel force-pushed the update-browser-versions branch 4 times, most recently from d89ec5e to 6a9d7b0 Compare July 20, 2023 14:49
@afcapel afcapel force-pushed the update-browser-versions branch 8 times, most recently from c1b7456 to bed325a Compare August 3, 2023 10:28
@seanpdoyle
Copy link
Contributor

As additional data points, both #1121 and #1122 timed out after 6 hours.

I've re-forked the repository and re-opened them as #1128 and #1127 to give them a chance to re-run.

Is this branch still viable as a solution?

@seanpdoyle
Copy link
Contributor

After more investigation, I believe the issue is that forks do not inherit repository secrets:

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

This means that contributors submitting pull requests are executing their own suites in their own CI environments without access to SAUCE_USERNAME or SAUCE_ACCESS_KEY.

Do contributors need to register their own accounts and get their own secrets?

@afcapel
Copy link
Contributor Author

afcapel commented Jan 30, 2024

Do contributors need to register their own accounts and get their own secrets?

Ugh, that's quite a hurdle for contributing. Ideally we would run the tests from the GitHub actions instance if SAUCE_KEY is not present, and use Sauce Labs only on PRs. Running the tests locally is much more reliable than CI.

But there must be something else going on. The test randomly fail some times even when the SAUCE_KEY is present. Not sure exactly why, but the error messages look like connection problems.

afcapel added a commit that referenced this pull request Feb 2, 2024
Allows forks to run tests on GitHub Actions without having to have access
to the SauceLabs secret.

Ref. #1072 (comment)
afcapel added a commit that referenced this pull request Feb 2, 2024
Allows forks to run tests on GitHub Actions without having to have access
to the SauceLabs secret.

Ref. #1072 (comment)
@afcapel
Copy link
Contributor Author

afcapel commented Feb 2, 2024

@seanpdoyle I've updated the CI script to only run tests on SauceLabs if it has access to an SAUCE_ACCESS_KEY.

#1130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants