Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prisma config update to work with new supabase supavisor #1245

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

pyrotank41
Copy link

@pyrotank41 pyrotank41 commented Feb 13, 2024

Summary by CodeRabbit

  • New Features
    • Introduced support for using Supabase as a database option, including new configuration parameters.
  • Refactor
    • Added validation for database URLs to ensure compatibility and security.
  • Documentation
    • Updated documentation to reflect the changes in database configuration.

Copy link

vercel bot commented Feb 13, 2024

@pyrotank41 is attempting to deploy a commit to the Typebot Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

coderabbitai bot commented Feb 13, 2024

Walkthrough

The recent update introduces support for using Supabase as the database backend by adding new configuration parameters. Specifically, it includes the DATABASE_URL and DIRECT_URL for database connections. Additionally, there's a validation step to ensure the DIRECT_URL starts with 'postgres', and the Prisma schema has been updated to accommodate a new directUrl field in the datasource configuration, enhancing the flexibility and integration capabilities with Supabase.

Changes

File Path Change Summary
apps/docs/self-hosting/configuration.mdx Added parameters DATABASE_URL and DIRECT_URL for Supabase database usage. Added DATABASE_DIRECT_URL for migrations.
packages/env/env.ts Introduced validation for DATABASE_DIRECT_URL to ensure it starts with 'postgres'.
packages/prisma/postgresql/schema.prisma Updated schema to include a new directUrl field in datasource configuration.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 191aeb0 and 24c735d.
Files selected for processing (3)
  • apps/docs/self-hosting/configuration.mdx (1 hunks)
  • packages/env/env.ts (1 hunks)
  • packages/prisma/postgresql/schema.prisma (1 hunks)
Additional comments: 2
packages/prisma/postgresql/schema.prisma (1)
  • 7-8: The addition of directUrl = env("DIRECT_URL") in the datasource configuration is correct and follows Prisma's conventions for environment variable usage.
apps/docs/self-hosting/configuration.mdx (1)
  • 32-37: The documentation for using Supabase as the database has been correctly updated with DATABASE_URL and DIRECT_URL parameters. Ensure the URLs provided in the description are accurate and lead to relevant Supabase documentation or integration guides.

packages/env/env.ts Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 24c735d and 7e9f081.
Files selected for processing (3)
  • apps/docs/self-hosting/configuration.mdx (1 hunks)
  • packages/env/env.ts (1 hunks)
  • packages/prisma/postgresql/schema.prisma (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • apps/docs/self-hosting/configuration.mdx
  • packages/env/env.ts
  • packages/prisma/postgresql/schema.prisma

Copy link
Author

@pyrotank41 pyrotank41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! does this work?

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7e9f081 and 9e14aeb.
Files selected for processing (3)
  • apps/docs/self-hosting/configuration.mdx (1 hunks)
  • packages/env/env.ts (1 hunks)
  • packages/prisma/postgresql/schema.prisma (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • apps/docs/self-hosting/configuration.mdx
  • packages/env/env.ts
  • packages/prisma/postgresql/schema.prisma

baptisteArno
baptisteArno previously approved these changes Feb 16, 2024
Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 10:31am
landing-page-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 10:31am

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9e14aeb and 5f9752c.
Files selected for processing (1)
  • apps/docs/self-hosting/configuration.mdx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • apps/docs/self-hosting/configuration.mdx

@baptisteArno
Copy link
Owner

I prefer not to merge this as long as this issue is not tackled: prisma/prisma#23221

@wesleybpereira
Copy link

Is it now possible to install with Supabase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants