Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence efi helpers #3419

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Silence efi helpers #3419

wants to merge 2 commits into from

Conversation

jakogut
Copy link
Contributor

@jakogut jakogut commented Apr 26, 2024

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@jakogut jakogut requested a review from mtoman April 26, 2024 15:41
@flowzone-app flowzone-app bot enabled auto-merge April 26, 2024 15:45
@mtoman
Copy link
Contributor

mtoman commented Apr 28, 2024

lgtm

@mtoman
Copy link
Contributor

mtoman commented Apr 28, 2024

@resin-jenkins retest this please

3 similar comments
@mtoman
Copy link
Contributor

mtoman commented Apr 30, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Apr 30, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Apr 30, 2024

@resin-jenkins retest this please

@jakogut
os-helpers-efi: silence od stderr
701ddd8 
When parsing an efivar value, od will complain if a given file does not
exist, such as the SecureBoot variable.

Silence stderr to ignore this.

Change-type: patch
Signed-off-by: Joseph Kogut <joseph@balena.io>
@jakogut
os-helpers-efi: silence secure boot variable checks
c453954 
If the SecureBoot variable is non-existent, the parsed value is not an
integer, and test complains. Redirect stderr to silence this.

Change-type: patch
Signed-off-by: Joseph Kogut <joseph@balena.io>
@jakogut
Copy link
Contributor Author

jakogut commented May 3, 2024

@resin-jenkins retest this please

4 similar comments
@jakogut
Copy link
Contributor Author

jakogut commented May 6, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented May 6, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented May 8, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented May 8, 2024

@resin-jenkins retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtoman mtoman Awaiting requested review from mtoman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakogut @mtoman