Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: os: modem: fix curl command #3418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: os: modem: fix curl command #3418

wants to merge 1 commit into from
+2 −2

Conversation

rcooke-warwick
Copy link
Contributor

The modem test was broken when changing from ping to curl as part of 071c018. Here it is fixed

Change-type: patch

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@rcooke-warwick
Copy link
Contributor Author

Confirmed that it works with an autokit + iot-gate-imx8 DUT

@flowzone-app flowzone-app bot enabled auto-merge April 26, 2024 13:31
@rcooke-warwick rcooke-warwick mentioned this pull request Apr 26, 2024
Open
1 task
@vipulgupta2048
Copy link
Member

@resin-jenkins retest this please

2 similar comments
@vipulgupta2048
Copy link
Member

@resin-jenkins retest this please

@acostach
Copy link
Contributor

@resin-jenkins retest this please

@floion
Copy link
Collaborator

floion commented May 1, 2024

@resin-jenkins test this please

@floion floion closed this May 1, 2024
auto-merge was automatically disabled May 1, 2024 12:02

Pull request was closed

@floion floion reopened this May 1, 2024
@floion floion enabled auto-merge May 1, 2024 12:02
@acostach
Copy link
Contributor

acostach commented May 2, 2024

@resin-jenkins retest this please

@floion
Copy link
Collaborator

floion commented May 3, 2024

@resin-jenkins test this please

@alexgg
Copy link
Contributor

alexgg commented May 3, 2024

@resin-jenkins retest this please

@floion
Copy link
Collaborator

floion commented May 6, 2024

@resin-jenkins test this please

4 similar comments
@acostach
Copy link
Contributor

acostach commented May 7, 2024

@resin-jenkins test this please

@rcooke-warwick
Copy link
Contributor Author

@resin-jenkins test this please

@floion
Copy link
Collaborator

floion commented May 8, 2024

@resin-jenkins test this please

@vipulgupta2048
Copy link
Member

@resin-jenkins test this please

@floion
Copy link
Collaborator

floion commented May 19, 2024

@resin-jenkins test this please

@rcooke-warwick @alexgg
tests: os: modem: fix curl command
6a62c9f 
The modem test was broken when changing from ping to curl as part of 071c018. Here it is fixed

Change-type: patch
Signed-off-by: Ryan Cooke <ryan@balena.io>
@acostach
Copy link
Contributor

@resin-jenkins retest this please

@floion
Copy link
Collaborator

floion commented May 21, 2024

@resin-jenkins test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostach acostach acostach approved these changes

@vipulgupta2048 vipulgupta2048 vipulgupta2048 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rcooke-warwick @vipulgupta2048 @acostach @floion @alexgg