Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update os-config schema for config.json migration #3227

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cywang117
Copy link
Contributor

@cywang117 cywang117 commented Aug 17, 2023

Draft until os-config binary changes are complete; should be released together with os-config binary

See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
Change-type: minor


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

cywang117 added a commit to balena-os/os-config that referenced this pull request Aug 21, 2023
This also includes the binary querying /os/v2/config instead,
which has a different response format. The changes to the response
format are reflected in the updated tests in this commit.

See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
See: balena-os/meta-balena#3227
See: balena-io/open-balena-api#1394
Signed-off-by: Christina Ying Wang <christina@balena.io>
Change-type: major
cywang117 added a commit to balena-os/os-config that referenced this pull request Aug 24, 2023
This also includes the binary querying /os/v2/config instead,
which has a different response format. The changes to the response
format are reflected in the updated tests in this commit.

See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
See: balena-os/meta-balena#3227
See: balena-io/open-balena-api#1394
Signed-off-by: Christina Ying Wang <christina@balena.io>
Change-type: major
cywang117 added a commit to balena-os/os-config that referenced this pull request Aug 28, 2023
This also includes the binary querying /os/v2/config instead,
which has a different response format. The changes to the response
format are reflected in the updated tests in this commit.

See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
See: balena-os/meta-balena#3227
See: balena-io/open-balena-api#1394
Signed-off-by: Christina Ying Wang <christina@balena.io>
Change-type: major
cywang117 added a commit to balena-os/os-config that referenced this pull request Sep 13, 2023
The response from querying /os/v1/config has changed slightly,
the changes to the response are reflected in the updated tests
in this commit.

See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
See: balena-os/meta-balena#3227
See: balena-io/open-balena-api#1394
Signed-off-by: Christina Ying Wang <christina@balena.io>
Change-type: minor
@cywang117 cywang117 force-pushed the os-config-schema-v2 branch 2 times, most recently from 2a5f414 to c40ea9c Compare September 13, 2023 23:08
@cywang117 cywang117 force-pushed the os-config-schema-v2 branch 2 times, most recently from 38fb5ae to bdcdc2e Compare November 24, 2023 21:21
cywang117 and others added 3 commits November 24, 2023 13:21
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
Signed-off-by: Christina Ying Wang <christina@balena.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants