New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update os-config schema for config.json migration #3227
Draft
cywang117
wants to merge
3
commits into
master
Choose a base branch
from
os-config-schema-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cywang117
force-pushed
the
os-config-schema-v2
branch
from
August 17, 2023 22:39
4ac6e92
to
6f5d2f7
Compare
rcooke-warwick
force-pushed
the
os-config-schema-v2
branch
from
August 21, 2023 10:06
6f5d2f7
to
5035621
Compare
cywang117
added a commit
to balena-os/os-config
that referenced
this pull request
Aug 21, 2023
This also includes the binary querying /os/v2/config instead, which has a different response format. The changes to the response format are reflected in the updated tests in this commit. See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901 See: balena-os/meta-balena#3227 See: balena-io/open-balena-api#1394 Signed-off-by: Christina Ying Wang <christina@balena.io> Change-type: major
cywang117
added a commit
to balena-os/os-config
that referenced
this pull request
Aug 24, 2023
This also includes the binary querying /os/v2/config instead, which has a different response format. The changes to the response format are reflected in the updated tests in this commit. See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901 See: balena-os/meta-balena#3227 See: balena-io/open-balena-api#1394 Signed-off-by: Christina Ying Wang <christina@balena.io> Change-type: major
cywang117
added a commit
to balena-os/os-config
that referenced
this pull request
Aug 28, 2023
This also includes the binary querying /os/v2/config instead, which has a different response format. The changes to the response format are reflected in the updated tests in this commit. See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901 See: balena-os/meta-balena#3227 See: balena-io/open-balena-api#1394 Signed-off-by: Christina Ying Wang <christina@balena.io> Change-type: major
cywang117
added a commit
to balena-os/os-config
that referenced
this pull request
Sep 13, 2023
The response from querying /os/v1/config has changed slightly, the changes to the response are reflected in the updated tests in this commit. See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901 See: balena-os/meta-balena#3227 See: balena-io/open-balena-api#1394 Signed-off-by: Christina Ying Wang <christina@balena.io> Change-type: minor
cywang117
force-pushed
the
os-config-schema-v2
branch
2 times, most recently
from
September 13, 2023 23:08
2a5f414
to
c40ea9c
Compare
cywang117
force-pushed
the
os-config-schema-v2
branch
2 times, most recently
from
November 24, 2023 21:21
38fb5ae
to
bdcdc2e
Compare
See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901 Change-type: minor Signed-off-by: Christina Ying Wang <christina@balena.io>
Change-type: patch Signed-off-by: Zahari Petkov <zahari@balena.io>
Signed-off-by: Christina Ying Wang <christina@balena.io>
cywang117
force-pushed
the
os-config-schema-v2
branch
from
November 24, 2023 21:21
bdcdc2e
to
1747b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until os-config binary changes are complete; should be released together with os-config binary
See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
Change-type: minor
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines