Add a default export which maps OData names to typescript interfaces #64
Conversation
src/generate.ts
Outdated
| ` ${sqlNameToODataName(tableName)}: ${modelNameToCamelCaseName(m.tables[tableName].name)};`, | ||
| ) | ||
| .join('\n')} | ||
| // Synonyms |
There was a problem hiding this comment.
Do we always want to output this comment even when no synonyms exist?
There was a problem hiding this comment.
I'm not that fussed either way personally but I'll look into either removing or replacing it with a // No synonyms to make it clear that there are no synonyms vs something weird happening/a bug
src/generate.ts
Outdated
| @@ -188,5 +188,21 @@ ${Object.keys(m.tables) | |||
| return tableToInterface(m, t); | |||
| }) | |||
| .join('\n\n')} | |||
|
|
|||
| export default interface Model { | |||
There was a problem hiding this comment.
How about using a weirder name in order to reduce the chance of conflicting w/ an actual resource that consumer might have?
Eg $ModelMap (in the SDK, as you probably saw, we use the poorly inspired ResourceTypeMap)
There was a problem hiding this comment.
@thgreasi I thought because it is a default export that it wouldn't clash, but it turns out it would.. I've renamed it to $Model to avoid clashes and the name shouldn't usually matter because it should just be accessed via import type Model from ...
Page-
force-pushed
the
odata-to-ts-interface
branch
3 times, most recently
from
ecb9352
to
003f566
Compare
Page-
force-pushed
the
odata-to-ts-interface
branch
2 times, most recently
from
bb7b9f9
to
37a490c
Compare
Change-type: minor
Page-
force-pushed
the
odata-to-ts-interface
branch
from
37a490c
to
877a798
Compare
No description provided.