Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in customToJSON documentation #7338

Closed
wants to merge 1 commit into from

Conversation

dushmanta05
Copy link

This pull request fixes Issue #7337.

It fixes a typo in the customToJSON section of the Sails.js documentation. The word action2 was corrected to action.

@sailsbot
Copy link

Thanks for submitting this pull request, @dushmanta05! We'll look at it ASAP.

In the mean time, here are some ways you can help speed things along:

  • discuss this pull request with other contributors and get their feedback. (Reactions and comments can help us make better decisions, anticipate compatibility problems, and prevent bugs.)
  • ask another JavaScript developer to review the files changed in this pull request. (Peer reviews definitely don't guarantee perfection, but they help catch mistakes and enourage collaborative thinking. Code reviews are so useful that some open source projects require a minimum number of reviews before even considering a merge!)
  • if appropriate, ask your business to sponsor your pull request. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • make sure you've answered the "why?" (Before we can review and merge a pull request, we feel it is important to fully understand the use case: the human reason these changes are important for you, your team, or your organization.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@DominusKelvin
Copy link
Contributor

Hey @dushmanta05 thanks for the PR on first look it may look like a typo but actions2 is an actual concept in Sails and that line in the docs was referring to whether you use res.send with classic(Express-like) actions or the modern machine implementation of actions called action2.

You can see here for more on actions2.

You can also see this reference in the docs for actions2

@DominusKelvin
Copy link
Contributor

@dushmanta05 I am closing this PR now thanks for taking out the time for submitting this. 💯

@dushmanta05
Copy link
Author

@DominusKelvin Thanks for the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants