Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Add documentation for select and omit #7208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cincodenada
Copy link

select() and omit() are mentioned fleetingly in the find docs, but don't have
their own documentation. This adds basic docs for their usage.

@sailsbot
Copy link

sailsbot commented Mar 3, 2022

Hi @cincodenada! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with [proposal], [patch], [fixes #<issue number>], [implements #<other PR number>], or [misc]? Once you've edited it, I'll take another look!

@cincodenada cincodenada changed the title Add documentation for select and omit [patch] Add documentation for select and omit Mar 3, 2022
@sailsbot
Copy link

sailsbot commented Mar 3, 2022

Thanks for submitting this pull request, @cincodenada! We'll look at it ASAP.

In the mean time, here are some ways you can help speed things along:

  • discuss this pull request with other contributors and get their feedback. (Reactions and comments can help us make better decisions, anticipate compatibility problems, and prevent bugs.)
  • ask another JavaScript developer to review the files changed in this pull request. (Peer reviews definitely don't guarantee perfection, but they help catch mistakes and enourage collaborative thinking. Code reviews are so useful that some open source projects require a minimum number of reviews before even considering a merge!)
  • if appropriate, ask your business to sponsor your pull request. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • make sure you've answered the "why?" (Before we can review and merge a pull request, we feel it is important to fully understand the use case: the human reason these changes are important for you, your team, or your organization.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@cincodenada
Copy link
Author

cincodenada commented Mar 4, 2022

Where in the guidelines does it mention prefixing the PR title with the topic? I looked through what I think is the entire guidelines and don't think I saw it anywhere, but the sailsbot message seems to imply that I should have known about the pull request title from reading the guidelines.

I also wasn't sure what to subtitle my PR with, because there wasn't anything specifically about docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants