Fixing session fixation vulnerabilities in default application #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prevent session fixation attacks. Furthermore, it prevents CSRF fixation attacks by forcing the recreation of the csrfSecret session field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch regenerates the session identifier on login/signup, fixing session fixation vulnerabilities in the default application. Furthermore, the proposed change prevents CSRF fixation attacks by forcing the recreation of the
csrfSecretsession field.Notice that the
session.regenerate(callback)method creates a newSessioninstance, removing all existing attributes from the session. To preserve specific session values between unauthenticated and authenticated states it would be possible to define a configurable allow-list of attributes that should be copied from the old session into the new one.We also urge the maintainers to update the official Sails documentation and incorporate the proposed authentication patterns to avoid session fixation vulnerabilities.
This PR was submitted as requested by the project maintainers after private conversation.