Fix transformation order in pivot documentation #71
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the transformation order was incorrect for explaining the behavior of the `(pivot)` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @baku89, thank you for creating glisp. I really like the user interface and am trying to learn the language right now.
While reading the tutorial I saw two things in the transform documentation:
(mat2d/*)in the first pivot example that only had 1 argument, so it was a no-op. I was confused by this part at first, but when I removed it nothing changed.[-20 -20]translation should be the last argument (applied first), rather than the first one (applied last).Very small fix, I'll update the jp version code as well.