Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS support implement #46 #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jevonmao
Copy link

@jevonmao jevonmao commented Jun 19, 2021

Description

Added macOS support by adding macOS specifier to package.swift file. No other change is made to the codebase.

Note: Adding macOS support will break some examples usage that uses class such as UIColor and UIScreen, @badrinathvm you might want to update those examples.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • This change requires a documentation update

How Has This Been Tested

No additional unit test added.

Test Configuration

  • Xcode version: 12.5
  • Device/Simulator: Simulator iPhone iOS 15
  • iOS version: 15.0
  • MacOSX version: 11.5 Beta

Checklist:

For checklist items not applicable, mention NA in front of it with some comment if applicable.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • Add comments to code particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes before pushing the pull request

@badrinathvm
Copy link
Owner

Thank you for PR. I will have look at breaking examples and add necessary availability checks.

@badrinathvm
Copy link
Owner

Also can u update in podspec file as well for macOS ?

@jevonmao
Copy link
Author

Also can u update in podspec file as well for macOS ?

@badrinathvm, Done.

Adding macOS support will break some examples usage that uses class such as UIColor and UIScreen

Also, I adopted all the example views for macOS by changing existing code to cross-platform APIs.

@badrinathvm badrinathvm self-requested a review June 20, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants