Skip to content
This repository has been archived by the owner on Feb 5, 2023. It is now read-only.

Try to run on Heroku #41

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Try to run on Heroku #41

wants to merge 8 commits into from

Conversation

paulmelnikow
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Jul 23, 2019 •
edited

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://svg-to-image-proxy-git-heroku.shields11.now.sh

@paulmelnikow paulmelnikow temporarily deployed to shields-raster-staging July 23, 2019 18:12 Inactive
@vercel vercel bot requested a deployment to staging July 23, 2019 18:14 Abandoned
@paulmelnikow paulmelnikow temporarily deployed to shields-raster-staging July 23, 2019 18:17 Inactive
platan
platan reviewed Jul 23, 2019
View reviewed changes
app.json Outdated
"keywords": ["svg", "png", "image", "proxy"],
"website": "https://shields.io/",
"repository": "https://github.com/badges/svg-to-iamge-proxy",
"logo": "httpx://shields.io/favicon.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have favicon at https://shields.io/favicon.png, but why httpx://shields.io/favicon.png :-)? It this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I mistyped!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@platan Any interest in taking a crack at getting this running on Heroku?

@paulmelnikow paulmelnikow temporarily deployed to shields-raster-staging July 23, 2019 19:07 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-raster-staging July 23, 2019 19:13 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-raster-staging July 23, 2019 19:22 Inactive
@calebcartwright
Copy link
Member

How's this looking? I don't see it on the Heroku dashboard

@paulmelnikow
Copy link
Member Author

It's not working yet. I haven't gotten the right combination of a small enough slug with a working Chromium. I'm happy to add you to the app though.

@calebcartwright
Copy link
Member

Any concerns that the puppeteer update in #44 (which includes Chromium 77.0.3844.0) make things more difficult here?

@paulmelnikow
Copy link
Member Author

🤷‍♂no idea!

@paulmelnikow paulmelnikow mentioned this pull request Sep 20, 2019
Closed
@paulmelnikow paulmelnikow marked this pull request as draft June 10, 2020 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platan platan platan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@paulmelnikow @calebcartwright @platan