Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve github auth providers #24726

Merged
merged 2 commits into from May 15, 2024
Merged

docs: improve github auth providers #24726

merged 2 commits into from May 15, 2024

Conversation

vinzscam
Copy link
Member

Hey, I just made a Pull Request!

Improved the Github auth docs, specifying only a single resolver in the example.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@vinzscam
docs: improve github auth providers
8c8d36b 
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
@vinzscam vinzscam requested review from a team as code owners May 10, 2024 18:09
@vinzscam vinzscam requested review from freben and camilaibs May 10, 2024 18:09
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 10, 2024
@vinzscam vinzscam mentioned this pull request May 10, 2024
Open
2 tasks
awanlin
awanlin approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinzscam, one small nit but doesn't seem worth blocking this

docs/auth/github/provider.md Outdated Show resolved Hide resolved
@vinzscam @awanlin
Update docs/auth/github/provider.md
8472777 
Co-authored-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Rugvip
Rugvip approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍, :shipit:

@vinzscam vinzscam enabled auto-merge May 15, 2024 08:52
camilaibs
camilaibs approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@camilaibs camilaibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@vinzscam vinzscam merged commit fc160c0 into master May 15, 2024
21 checks passed
@vinzscam vinzscam deleted the github-auth-providers-docs branch May 15, 2024 09:12
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.28.0 release, scheduled for Tue, 18 Jun 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rugvip Rugvip Rugvip approved these changes

@camilaibs camilaibs camilaibs approved these changes

@awanlin awanlin awanlin approved these changes

@freben freben Awaiting requested review from freben freben is a code owner automatically assigned from backstage/maintainers

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vinzscam @Rugvip @camilaibs @awanlin