do not create a unique connection pool for every CacheService instance

[freben]

The old code created a new @keyv/redis or @keyv/memcache instance every time that anyone called getClient. That's fine if done once per plugin, but not if it's called over and over again. That creates a new connection pool per call, which gets abandoned by the caller (likely, if it's written in such a way that it calls getClient repeatedly in the first place) which piles up more and more active connections to the underlying cache store until it starts rejecting connections.

Could have gone all the way to memoizing on the options object to save on Keyv wrapper object overhead, but this felt like it would still cover all realistic use cases without having to worry about how that changes over time.

Ref: https://discord.com/channels/687207715902193673/1034089724664610938/1237307568410464256

[backstage-goalie]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage/backend-common	packages/backend-common	patch	v0.22.0-next.2

[drodil]

Great fix @freben ! Hope this gets shipped in the next release (tomorrow?)!

[Rugvip]

Nice! 👍

Let's

[github-actions]

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.27.0 release, scheduled for Tue, 14 May 2024.

[github-actions]

Uffizzi Cluster pr-24725 was deleted.