Added support for camerCase csp in app-config #24723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Changed Packages
|
Closed
2 tasks
vinzscam
force-pushed
the
fix-csp-camelCase
branch
from
ce0c4af
to
659b23a
Compare
github-actions
bot
removed
documentation
vinzscam
force-pushed
the
fix-csp-camelCase
branch
from
659b23a
to
b5ea989
Compare
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
vinzscam
force-pushed
the
fix-csp-camelCase
branch
from
b5ea989
to
2a61a25
Compare
vinzscam
changed the title
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
vinzscam
force-pushed
the
fix-csp-camelCase
branch
from
2a61a25
to
a1dc547
Compare
Rugvip
requested changes
May 10, 2024
| @@ -47,7 +47,7 @@ describe('readHelmetOptions', () => { | |||
| csp: { | |||
| key: ['value'], | |||
| 'img-src': false, | |||
| 'script-src-attr': ['custom'], | |||
| scriptSrcAttr: ['custom'], | |||
There was a problem hiding this comment.
Could we keep a test that makes sure we still support the old format too? Maybe with a deprecation warning too?
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
🎉
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
|
Uffizzi Cluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This PR adds support for camelCase CSP directives in app-config.
Fixes #24716
✔️ Checklist
Signed-off-byline in the message. (more info)