Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for github app to have emails #24701

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add support for github app to have emails #24701

wants to merge 1 commit into from
+9 −2

Conversation

mikeyhc
Copy link
Contributor

@mikeyhc mikeyhc commented May 8, 2024 •
edited

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@mikeyhc
add support for github app to have emails
155aaaf 
Signed-off-by: mikey <mikey@spotify.com>
@mikeyhc mikeyhc requested review from a team as code owners May 8, 2024 20:05
@mikeyhc mikeyhc requested review from freben, vinzscam and Edje-C May 8, 2024 20:05
@mikeyhc mikeyhc marked this pull request as draft May 8, 2024 20:05
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label May 8, 2024
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-backend-module-github plugins/catalog-backend-module-github patch v0.6.1-next.2

@Rugvip
Copy link
Member

Rugvip commented May 8, 2024

Afaik this is tricky, see the original change here: https://github.com/backstage/backstage/pull/5769/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freben freben Awaiting requested review from freben freben is a code owner automatically assigned from backstage/maintainers

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

@Edje-C Edje-C Awaiting requested review from Edje-C Edje-C is a code owner automatically assigned from backstage/catalog-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikeyhc @Rugvip