catalog-backend-module-github-org: fix default namespace for groups #24700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
…Provider Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
vinzscam
force-pushed
the
github-multi-org-fix-namespace
branch
from
f73e6c9
to
11c9f1f
Compare
2 tasks
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
github-actions
bot
added
the
documentation
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
vinzscam
force-pushed
the
github-multi-org-fix-namespace
branch
from
6520dc4
to
4cd526e
Compare
Rugvip
requested changes
May 10, 2024
| githubOrg: | ||
| - id: production | ||
| githubUrl: 'https://github.com', | ||
| orgs: ['org-a', 'org-b'], |
There was a problem hiding this comment.
Ah so it wasn't possible to configure this by org after all, that explains the code. Doesn't need to be done now but prolly makes sense to add support for Array<string | { name: string, groupNamespace?: string, userNamespace?: string}> in the future
| * | ||
| * If set to true, groups with the same name across different orgs will be considered the same group. | ||
| */ | ||
| defaultNamespace?: boolean; |
There was a problem hiding this comment.
Thinking that a good name for this could be alwaysUseDefaultNamespace?
| entities: [], | ||
| }) | ||
| .catch(error => { | ||
| console.error('Failed to clean up entities', error); |
awanlin
approved these changes
May 10, 2024
2 tasks
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Rugvip
approved these changes
May 13, 2024
👍Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
|
Uffizzi Cluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
As we are suggesting adopters to use the new
catalog-backend-module-github-orgwhen migrating to the new backend system, this PR fixes an issue where thecatalog-backend-module-github-orgwould create groups using the org as namespace instead of thedefaultnamespace.Now the module uses the
defaultnamespace for groups, in case a single org has been configured.✔️ Checklist
Signed-off-byline in the message. (more info)