Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-*-api: backport support for external route ref default targets + config route binding #24698

Merged
merged 10 commits into from May 15, 2024

Conversation

Rugvip
Copy link
Member

@Rugvip Rugvip commented May 8, 2024

Hey, I just made a Pull Request!

The new frontend system supports route binding through static configuration, for example:

app:
  routes:
    bindings:
      catalog.createComponent: catalog-import.importPage

It also lets you define default targets for external route references, for example:

export const registerComponentRouteRef = createExternalRouteRef({
  optional: true,
  defaultTarget: 'catalog-import.importPage',
});

This adds support for both of these features in the existing frontend system.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Rugvip added 6 commits May 8, 2024 17:13
…nd route binding through config

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
…ets and route binding through config

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip Rugvip requested review from a team as code owners May 8, 2024 15:49
@Rugvip Rugvip added do-not-merge merge-after-release This is a bit too scary to merge until after the next release labels May 8, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area labels May 8, 2024
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
example-app packages/app none v0.2.97-next.2
@backstage/core-app-api packages/core-app-api patch v1.12.4
@backstage/core-compat-api packages/core-compat-api patch v0.2.5-next.1
@backstage/core-plugin-api packages/core-plugin-api patch v1.9.2
@backstage/plugin-api-docs plugins/api-docs patch v0.11.5-next.2
@backstage/plugin-catalog-graph plugins/catalog-graph patch v0.4.5-next.2
@backstage/plugin-catalog plugins/catalog minor v1.20.0-next.2
@backstage/plugin-org plugins/org patch v0.6.25-next.2
@backstage/plugin-scaffolder plugins/scaffolder minor v1.19.4-next.2

Rugvip added 4 commits May 9, 2024 09:28
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip Rugvip removed do-not-merge merge-after-release This is a bit too scary to merge until after the next release labels May 14, 2024
@Rugvip Rugvip merged commit 639ad93 into master May 15, 2024
32 checks passed
@Rugvip Rugvip deleted the rugvip/binding-backport branch May 15, 2024 08:48
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.28.0 release, scheduled for Tue, 18 Jun 2024.

Copy link
Contributor

Uffizzi Cluster pr-24698 was deleted.

@Rugvip
Copy link
Member Author

Rugvip commented May 15, 2024

Merged by mistake, reverted and replaced by #24777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant