Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture doc update #24690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshjung
Copy link
Contributor

@joshjung joshjung commented May 8, 2024

Hey, I just made a Pull Request!

Some updates primarily to the architecture overview page to make things clearer, updating some visuals, fixing some broken links, and updating the documentation a bit in the microsite readme.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@joshjung joshjung requested review from a team as code owners May 8, 2024 12:44
@joshjung joshjung requested review from freben and vinzscam May 8, 2024 12:44
@github-actions github-actions bot added documentation Improvements or additions to documentation microsite Changes to backstage.io labels May 8, 2024
@joshjung joshjung force-pushed the jjung/architecture-doc-update branch from ae6ad07 to 08d9205 Compare May 8, 2024 12:46
@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@joshjung joshjung force-pushed the jjung/architecture-doc-update branch from 08d9205 to c0dac6d Compare May 8, 2024 12:48
…sues in the docs.

Signed-off-by: Joshua Jung <joshua.p.jung@gmail.com>
@joshjung joshjung force-pushed the jjung/architecture-doc-update branch from c0dac6d to 1bb9670 Compare May 8, 2024 16:16
@joshjung
Copy link
Contributor Author

joshjung commented May 9, 2024

FYI I have no clue why the above is failing! It appears to be a fluke, @Rugvip is there a way to trigger a rerun of the pipeline without committing something?

@aramissennyeydd
Copy link
Contributor

@joshjung I think the comment doesn't get deleted if the DCO check passes after it fails initially, you can see those results here. It should be safe to ignore the comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation microsite Changes to backstage.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants