Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NBS 1.0] Deprecate isomorphic git class #24605

Merged
merged 2 commits into from May 14, 2024
Merged

[NBS 1.0] Deprecate isomorphic git class #24605

merged 2 commits into from May 14, 2024

Conversation

camilaibs
Copy link
Contributor

@camilaibs camilaibs commented May 3, 2024 •
edited

Hey, I just made a Pull Request!

Closes: #24604
Deprecated isomorphic Git abstraction from the backend-common package.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@camilaibs camilaibs requested review from a team and backstage-service as code owners May 3, 2024 07:27
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label May 3, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented May 3, 2024 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/backend-common packages/backend-common patch v0.22.0-next.2
@backstage/plugin-scaffolder-node plugins/scaffolder-node patch v0.4.4-next.2

@camilaibs camilaibs linked an issue May 3, 2024 that may be closed by this pull request
Decide what to do with the Git abstraction and deprecated it from the backend-common package #24604
Closed
5 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited

Uffizzi Cluster pr-24605 was deleted.

@camilaibs camilaibs force-pushed the camilaibs/nbs10-move-git-abstraction-elsewhere branch 3 times, most recently from b874864 to d5b7233 Compare May 3, 2024 08:57
@camilaibs camilaibs mentioned this pull request May 3, 2024
Open
5 tasks
@camilaibs camilaibs force-pushed the camilaibs/nbs10-move-git-abstraction-elsewhere branch 2 times, most recently from d9f77da to 50035bd Compare May 8, 2024 08:25
Rugvip
Rugvip requested changes May 10, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

Just a few nits

.changeset/famous-crabs-laugh.md Outdated Show resolved Hide resolved
packages/backend-common/src/reading/git.ts Outdated Show resolved Hide resolved
@camilaibs
refactor(backend-common): deprecate isomorphic git class
57f692e 
Signed-off-by: Camila Belo <camilaibs@gmail.com>
@camilaibs
refactor: apply review suggestions
f633efa 
Signed-off-by: Camila Belo <camilaibs@gmail.com>
@camilaibs camilaibs force-pushed the camilaibs/nbs10-move-git-abstraction-elsewhere branch from 50035bd to f633efa Compare May 13, 2024 08:37
@camilaibs camilaibs requested a review from Rugvip May 13, 2024 08:38
Rugvip
Rugvip approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 :shipit:

benjdlambert
benjdlambert approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉 Thanks for dealing with this! 🎉

@vinzscam vinzscam merged commit f331d48 into master May 14, 2024
38 checks passed
@vinzscam vinzscam deleted the camilaibs/nbs10-move-git-abstraction-elsewhere branch May 14, 2024 08:09
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.27.0 release, scheduled for Tue, 14 May 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@Rugvip Rugvip Rugvip approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decide what to do with the Git abstraction and deprecated it from the backend-common package
4 participants
@camilaibs @benjdlambert @Rugvip @vinzscam