Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with the Git abstraction and deprecated it from the backend-common package #24604

Closed
5 tasks done
Tracked by #24493
camilaibs opened this issue May 3, 2024 · 2 comments · Fixed by #24605
Closed
5 tasks done
Tracked by #24493
Assignees
Labels
area:core Related to the Core Backstage Framework backend

Comments

@camilaibs
Copy link
Contributor

camilaibs commented May 3, 2024

Context

Ref: #24493

Before the stable release, we will be deprecating the backend common package, and the Git abstraction will be moved elsewhere. This task is for us to decide what to do with the Git abstraction, and then make the changes according to our decision.

Open questions

Some of it can be moved into scaffolder-node implementations, but more discussion is needed.

Suggested approach

  • Determine whether more than one plugin uses it
  • Examine whether it fits with a new backend concept
  • Extract the files and update the references import statements
  • Deprecate the export from the backend common package (re-export from the new package with "@deprecated" as a annotation)
  • Verify everything is working as before and update any documentation
@camilaibs camilaibs self-assigned this May 3, 2024
@camilaibs camilaibs added backend area:core Related to the Core Backstage Framework labels May 3, 2024
@camilaibs camilaibs linked a pull request May 3, 2024 that will close this issue
5 tasks
@javiermartingonzalez
Copy link

Hello, how can I use the Git abstraction after deprecation?

@camilaibs
Copy link
Contributor Author

Hi @javiermartingonzalez 👋🏻 , as we mentioned in the changelog, the abstraction will be removed from the backstage backend packages because it is not used in the framework itself, the implementation was created by the community and was only used by plugins. We recommend you copying the implementation to you plugin in case you are using it or as it’s a fairly thin wrapper on top of the underlying library you may enjoy using that directly instead of the wrapper 🙂 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Related to the Core Backstage Framework backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants