add error message on create impediment with wrong blocks id

backlogs · Nov 5, 2019 · 60d2239 · 60d2239
1 parent 3d02b95
commit 60d2239
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/controllers/rb_impediments_controller.rb b/app/controllers/rb_impediments_controller.rb
@@ -9,7 +9,8 @@ def create
     begin
       @impediment = RbTask.create_with_relationships(params, User.current.id, @project.id, true)
     rescue => e
-      render :text => e.message.blank? ? e.to_s : e.message, :status => 400
+      Rails.logger.error(e.message.blank? ? e.to_s : e.message)
+      render :partial => "backlogs/model_errors", :object => { "base" => e.message.blank? ? e.to_s : e.message }, :status => 400
       return
     end
 

diff --git a/app/models/rb_task.rb b/app/models/rb_task.rb
@@ -93,8 +93,6 @@ def self.create_with_relationships(params, user_id, project_id, is_impediment =
 
     task.save!
 
-
-
     task.move_before params[:next] unless is_impediment # impediments are not hosted under a single parent, so you can't tree-order them
     task.update_blocked_list blocks.split(/\D+/) if is_impediment
     task.time_entry_add(params)