Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pmod handling in pspm_glm #700

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

Improve pmod handling in pspm_glm #700

wants to merge 36 commits into from

Conversation

dominikbach
Copy link
Contributor

Fixes #191 and fixes #195 .

Changes proposed in this pull request:

  • initialise all pmods used in a multiple timing definition, i.e. if a pmod is defined for a condition which does not occur in session 1, then ensure that empty pmods with respective names are created in pspm_get_timing
  • write a test in pspm_glm to check that this is working

Dominik Bach and others added 30 commits April 12, 2024 14:53
modify pspm_combine_markerchannels
5e40e47
modify pspm_convert_au2unit and pspm_convert_area2diameter
a803376
fix pspm_load_channel
9b391cc
modify pspm_convert_hb2hp
cb6813c
modify pspm_convert_ppg2hb & pspm_emg_pp
9e5d630
modify pspm_find_sounds
2608a84
modify pspm_pupil_correct_eyelink
3ecf795
modify pspm_resp_pp
25345c1
modify pspm_scr_pp
545af94
modify pspm_pp
d69277b
modify pspm_merge
5e973c7
modify pspm_split_sessions
48a9edb
modify pspm_remove_epochs
9d62414
modify pspm_trim
8b092c1
modify pspm_import
afc20b9
modify pspm_dcm
ffe2f70
modify pspm_dcm_inv
ae4a435
modify pspm_glm
ba1d6ff
remove varargout in pspm_sf_... and pspm_transfer_function
91d3fca
modify pspm_version
72eaf15
fixes after testing
06bad35
fixes after testing
cb29ec1
@teddychao
Merge branch 'develop' into unify-function-output
31618c4
@dominikbach
Merge branch 'develop' into unify-function-output
f2225b9
modify pspm_interpolate
c88cca3
improve pspm_select_channels
94cfdc8
test fix
109035e
test fix
6b9c365
fixes
a4596b7
fix pspm_combine_markerchannels
d55a899
@dominikbach dominikbach self-assigned this Apr 26, 2024
@dominikbach dominikbach added the In Progress Currently being worked on label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dominikbach dominikbach

Labels
In Progress Currently being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initialise pmod structure in pspm_glm Parameter modulation only for several conditions, not all
2 participants
@dominikbach @teddychao