Improve pspm_trim to handle missing epoch files
#696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569 .
Overview
pspm_split_sessionsallows splitting an associated missing epochs file. This functionality could more easily be implemented inpspm_trimand would then allow users to also just trim a missing epochs file (a use case in a recent internal project).Changes proposed in this pull request:
pspm_trimto trim a missing epochs filepspm_split_sessionspspm_trimby using core functions for creating indicespspm_epochs2logicalto ensure the index is not longer than the original epochNo tests for the new feature are implemented - this should be fixed in a separate PR. At the moment, the new feature is indirectly tested via
pspm_split_sessions_test.