Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job disk resource limits should be honoured for urldownload storage provider #3975

Closed

Conversation

udsamani
Copy link
Collaborator

@udsamani udsamani commented May 6, 2024

This PR aims at the following

  • For urldownload storage provider, while getting volume size we send a HEAD request to the server.
  • If the size is obtained we send that size, if not the error is thrown.
  • Currently with this PR we do not take care of the case when server does not respond with correct size.

Copy link

coderabbitai bot commented May 6, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frrist frrist linked an issue May 6, 2024 that may be closed by this pull request
@udsamani udsamani marked this pull request as ready for review May 6, 2024 23:21
@udsamani
Copy link
Collaborator Author

udsamani commented May 6, 2024

@frrist @wdbaruni Please review whenever you get a chance ! Thank you !

@udsamani udsamani force-pushed the urldownload-storage-provider branch from 6d2a87f to 6d5321d Compare May 7, 2024 15:52
@udsamani
Copy link
Collaborator Author

udsamani commented May 7, 2024

Rebased on top of main with new commit.

@udsamani udsamani changed the title Fixes #3653 fix: Job disk resource limits are not honoured May 7, 2024
@udsamani udsamani changed the title fix: Job disk resource limits are not honoured Job disk resource limits should be honoured for urldownload storage provider May 7, 2024
@frrist frrist requested review from wdbaruni and frrist May 8, 2024 19:27
Copy link
Member

@frrist frrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! LGTM.

@udsamani udsamani force-pushed the urldownload-storage-provider branch from 81482f9 to 7fb9088 Compare May 13, 2024 23:17
@udsamani
Copy link
Collaborator Author

Due to issues with Circle CI, where CI does not run on forks and fails with 403. Abandoning this PR. Creating new branch by cloning the repo from bacalhau itself and opening a new PR.

@udsamani udsamani closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Job disk resource limits are not honoured
2 participants