ExecutionTimeout to fail executions instead of jobs

[wdbaruni]

This work is a pre-requirement for job queues as the orchestrator is currently failing jobs that take longer than ExecutionTimeout from the time they were submitted. ExecutionTimeout should only fail executions that have been running for too long, and not fail jobs. If a job haven't started and has been in the queue for too long, then this timeout should take effect as there will be other config to timeout of fail a job has been in the queue for too long or has been retried too many times.

A side effect of this PR is that timed out executions will be retried by the scheduler on other nodes until one succeed or no more nodes to retry. This will be handled in next job queue related PRs

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[frrist]

Three major points of concern:

• Parallelism in Housekeeping has several issues, one of which the potential for panicking. Suggest adopting the workerpool package I mentioned instead of implementing our own.
• Don't embed context.Context in the housekeeping structure.
• We need to be mocking time in our tests, especially as this area of the code base grows.

[frrist]

I think we should avoid including spaces in topic names. Let's opt for Camel Case.

[wdbaruni]

Topics main use is improving readability of events and let users understand which component or lifecycle or job orchestration the event is related. Not an internal detail and not intended to be consumed to other applications.

As the goal is improve human readability, allowing spaces can be improve the user experience and will improve how we display them on the CLI and UI without having to truncate them or wrap them at weird palces

[wdbaruni]

Parallelism in Housekeeping has several issues, one of which the potential for panicking. Suggest adopting the workerpool package I mentioned instead of implementing our own.

Not sure about the several issues. You pointed to one issue with a wrong call to waitGroup.Done() and that was fixed. You forgot to mention the workerpool package, but the semaphore seem to be working fine. The other requirement I have is I don't want the housekeeper to start another iteration before all tasks are completed, and thats why I am using the waitGroup

Don't embed context.Context in the housekeeping structure.

Fixed

We need to be mocking time in our tests, especially as this area of the code base grows.

Answered inline

[frrist]

Here's the worker pool package: https://github.com/gammazero/workerpool

The several issues were embedded context in structure, and the potential for panic with the wait group. The look to be addressed now will give another review in a sec.

[wdbaruni]

I've previously looked into the worker pool library you mentioned, and it doesn't enable waiting for housekeeping tasks before calling the iteration as complete and starting another one. Our requirements are pretty simple and I don't see a need for such a library at this point. The semaphore is limiting the number of concurrent tasks, which is what the workerpool library does, and the waitGroup is preventing iterations from overlapping with each other, which the workerpool library is missing.