Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make workload-onboarding examples testable #3965

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make workload-onboarding examples testable #3965

wants to merge 3 commits into from

Conversation

js-ts
Copy link
Contributor

@js-ts js-ts commented Apr 30, 2024 •
edited

This is ran along side the bashtub tests but it isn't a bashtub test itself, since the bashtub tests execute sequentially

Taking a subset of examples and making them testable
All Examples are executed in parallel
Test Passes when the Job is complete and the exit code is 0

when test passes this badge is displayed in the Example markdown
Static Badge

when It fails this batch is disaplayed
Static Badge

@js-ts
Squashed commit of the following:
d277369 
commit 9d2912f
Merge: 6a7f6c9 d51e57c
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Mon Apr 29 02:50:23 2024 +0530

    Merge branch 'main' into improve-bashtub-coverage

commit 6a7f6c9
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Mon Apr 29 01:19:54 2024 +0530

    Fix Majority of Tests

commit 4992326
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Fri Apr 26 11:47:26 2024 +0530

    Fixes

commit e111766
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Thu Apr 18 18:04:03 2024 +0530

    Fix Job Generation

commit 6bac66c
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Thu Apr 18 03:15:45 2024 +0530

    Add Job Generation

commit 9243553
Merge: 7fc2605 f453e32
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Wed Apr 17 20:08:13 2024 +0530

    Merge branch 'main' of https://github.com/bacalhau-project/bacalhau into improve-bashtub-coverage

commit 7fc2605
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Tue Apr 2 00:48:43 2024 +0530

    Fixes in failing tests on production

commit 0acadbe
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Mon Apr 1 20:25:35 2024 +0530

    Add metadata and update tests

commit c81edd8
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Mon Apr 1 15:34:00 2024 +0530

    Option to specify config to run tests against your private cluster

commit 7a0e8fc
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Mon Apr 1 14:19:31 2024 +0530

    fix1

commit c62e955
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Mon Apr 1 14:15:27 2024 +0530

    fix

commit 244fb34
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Mon Apr 1 13:48:01 2024 +0530

    Allow Passing in cluster type as an argument

commit b8e13e0
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Mon Apr 1 02:36:54 2024 +0530

    REVERT COMMITS and add spawn cluster to every test

commit 60b7f9c
Author: frrist <forrest@expanso.io>
Date:   Fri Mar 29 12:18:46 2024 -0700

    hack: getting the general idea worked out

commit 584ae15
Author: js-ts <vedantpadwalinfi@gmail.com>
Date:   Fri Mar 29 23:33:01 2024 +0530

    More Bashtub tests

commit feb399d
Author: js-ts <vedantpadwalinfi@gmail.com>
Date:   Fri Mar 29 23:31:24 2024 +0530

    Improve bashtub test coverage

commit 8d14955
Merge: a516adf 4780af6
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Fri Mar 29 12:09:26 2024 +0530

    Merge branch 'main' into bashtub-tests

commit a516adf
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Wed Mar 27 20:23:37 2024 +0530

    made chsnges as simon suggested

commit eb2d605
Author: Vedant Padwal <79689323+js-ts@users.noreply.github.com>
Date:   Thu Mar 21 13:23:28 2024 +0530

    Add simple tests
@js-ts
Make docs testable for workload-onboarding
a5a6cfb
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 30, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@js-ts
Copy link
Contributor Author

js-ts commented Apr 30, 2024

All of the V2 Declarative jobspecs aren't still merged into main and are in this branch https://github.com/bacalhau-project/bacalhau/tree/docupdating-a1qa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Engineering Planning
Status: Inbox
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@js-ts