This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
Filtertext #351
Open
Filtertext #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iget-esoares
reviewed
Apr 2, 2020
| * @param string $value | ||
| * @return $this | ||
| */ | ||
| public function whereMatch($field, $value) |
There was a problem hiding this comment.
Could you please remove this method? It was added and merged in PR #355
| * @param array $value | ||
| * @return $this | ||
| */ | ||
| public function whereNotInText($field, $value) |
There was a problem hiding this comment.
Maybe it can be renamed to whereNotMatchPhrase to be more specific on which query is made. What your thoughts?
| * Exclude results containing text | ||
| * Can't use 'term' because it's not analyzed | ||
| * | ||
| * @see https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-terms-query.html Terms query |
There was a problem hiding this comment.
| @@ -151,6 +151,44 @@ public function where($field, $value) | |||
| return $this; | |||
| } | |||
|
|
|||
| /** | |||
| * Exclude results containing text | |||
There was a problem hiding this comment.
Remove these comments since it's redundant
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a couple of methods for filtering texts. I needed them for my specific needs, guess someone else might find them useful as well.