Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add whereNotIn support #61

Merged
merged 1 commit into from
May 27, 2024
Merged

Add whereNotIn support #61

merged 1 commit into from
May 27, 2024

Conversation

Aniket-IN
Copy link
Contributor 

User::search($search)
  ->whereNotIn('id', [1, 2, 3])
  ->get()

babenkoivan
babenkoivan requested changes Mar 13, 2024
View reviewed changes
src/Factories/SearchParametersFactory.php
'terms' => [$field => $values],
])->values();

$filter = $filter->merge([[
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can just use $filter->push() to avoid double [ brackets?

Can I also ask you to add tests (see SearchParametersFactoryTest::test_search_parameters_can_be_made_from_builder_with_wherein_filter() and EngineSearchTest::test_search_result_can_be_filtered_with_wherein_clause() for the reference)?

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the stale Stale issue or pull request label Apr 13, 2024
@babenkoivan babenkoivan removed the stale Stale issue or pull request label Apr 13, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the stale Stale issue or pull request label May 14, 2024
@babenkoivan babenkoivan removed the stale Stale issue or pull request label May 14, 2024
@babenkoivan babenkoivan merged commit cb7cb4b into babenkoivan:master May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babenkoivan babenkoivan babenkoivan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aniket-IN @babenkoivan