Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Creature): Correct spells order for Broken-down Shredder (issue 18729) #18866

Merged
merged 2 commits into from May 12, 2024

Conversation

xubpwg
Copy link
Contributor

@xubpwg xubpwg commented May 7, 2024

Changes Proposed:

This PR proposes changes to:

  • Database (creatures).

Issues Addressed:

SOURCE:

Wrath retail

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue

Known Issues and TODO List:

Issue comment says that shredder can do melee attack on Classic, but I can't found any video for that behavior, so that question is still unclear

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label May 7, 2024
@Kitzunu
Copy link
Member

Kitzunu commented May 7, 2024

#18729 (comment) says that shredder can do melee attack on Classic, but I can't found any video for that behavior, so that question is still unclear

Bench is a reliable source, so if you can fix this it would be awesome

@elthehablo
Copy link
Contributor

Thanks for the PR

@elthehablo elthehablo merged commit 6b5ad72 into azerothcore:master May 12, 2024
16 checks passed
@xubpwg xubpwg deleted the fix_issue18729 branch May 13, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Creature): Broken-down Shredder has incorrect order of controlled spells.
4 participants