chore(Command/unstuck) use command with offline players #18855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CORE
walkline
suggested changes
May 2, 2024
|
@walkline Thanks for the suggestions, I will review all the ones you mentioned. I'll let you know when I make changes, so you can review them. Thank you. |
|
Do you know how to solve this? Because I had removed the if, and that warning did not appear. Anyway, I tested the code, and it works with the changes, I'll upload them now, but I would need to review that part.
|
Nyeriah
reviewed
May 2, 2024
src/server/database/Database/Implementation/CharacterDatabase.cpp
Outdated
Show resolved
Hide resolved
Nyeriah
reviewed
May 4, 2024
| if (handler->HasLowerSecurity(nullptr, target->GetGUID())) | ||
| return false; | ||
|
|
||
| ObjectGuid::LowType guid = sCharacterCache->GetCharacterGuidByName(target->GetName()).GetCounter(); |
There was a problem hiding this comment.
You don't need to access the cache at all here, you already got the guid info
CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_SEL_CHAR_HOMEBIND);
stmt->SetData(0, target->GetGUID().GetCounter());
PreparedQueryResult resultDB = CharacterDatabase.Query(stmt);There was a problem hiding this comment.
OK. I'll check it out. Thank you.
Nyeriah
reviewed
May 4, 2024
…zerothcore#18872) - Fix typo when loading reference loot templates - Closes azerothcore#18870 Co-authored-by: Jason Mok <jasonmok@Jasons-MacBook-Air-4.local>
* Init. Co-Authored-By: AnonXS <19734826+anonxs@users.noreply.github.com> * Adjust variable spacing. --------- Co-authored-by: AnonXS <19734826+anonxs@users.noreply.github.com>
Referenced commit(s): d34f64a
…upon opening (azerothcore#18877) * remove locked status from scarab coffer upon opening * add Scarab Coffer
Referenced commit(s): 9c363bd
…8876) * fixMaraPortal * convert to update statement
Referenced commit(s): c30cafe
…7951) (azerothcore#18850) * Fix some problems * Change the name of the spell
…ce (azerothcore#18849) fix: hitchance should decrease misschance
Referenced commit(s): 45ad5ac
…18843) * WIP maexxna web wrap * add custom summon web wrap * progress * save * something that works * update sql * cleanup script * clean sql * remove orientation from position * fix: cast web wrap on multiple targets * fix: web wraps should not attack * adjust vertical speed to reduce speed if close, avoid ceiling yeet * rename candIt to itr * remove unused wraps2 * style * use event instead of update(diff) * update spell_dbc sql * include player header to fix error: invalid use of incomplete type * include SpellAuraEffects header * fix Effects start at 1 in DBC * fix web wraps attacking * calc distance with hypotf, define vspeed ranges, remove trig webwrap enum * fixup! calc distance with hypotf, define vspeed ranges, remove trig webwrap enum * fix: call target selection with pos 0, use IsPlayer() * add validate * fixup! fix: call target selection with pos 0, use IsPlayer() * remove not needed header * remove empty lines * use registry macro * Revert "remove not needed header" This reverts commit 254717d.
Referenced commit(s): 5668e47
… summon Skeletons at that location (azerothcore#18892) * replace skeletonspawn scheduler with spellscript * Revert "replace skeletonspawn scheduler with spellscript" This reverts commit 974bcb8. * random target and remember position * target position instead of player * make pets valid targets for rain of bones * change 100 to 100.0f
…nd small mounds (azerothcore#18879) * Delete Flower and Small Dirt Mound Added flower and small mounds to the event * fix error * Update data/sql/updates/pending_db_world/rev_1715349752817459800.sql Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com> * Update data/sql/updates/pending_db_world/rev_1715349752817459800.sql Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com> * Update rev_1715349752817459800.sql --------- Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
Referenced commit(s): 3a4d321
Referenced commit(s): 7889a99
…zerothcore#18796) * Create rev_1713905765626834000.sql * unique loot * remove garbage * Update rev_1713905765626834000.sql
Referenced commit(s): 6594255
…g sniffed data (azerothcore#18898) * Create rev_1715713909070959500.sql * extra leftovers
Referenced commit(s): fd7c8a0
…azerothcore#18764) * fix(Scripts/PVP): correctly spawn generic gameobjects in Alterac Valley I've been "collecting" these in the DB for a while, now it's time to move these spawns to the AV script and actually spawn them. * add 2 additional generic gameobjects
Referenced commit(s): e2029c3
…kes (azerothcore#18883) * init * fixes
* fix(CI/PCH): revert ubuntu-22.04 to gcc12, add ubuntu-24.04 with gcc14 * also update nopch workflow * Update core-build-nopch.yml * Update core-build-pch.yml
Referenced commit(s): 4ae69cf
Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
|
I don't delete a branch anymore, in the end, when restoring it, obviously, I do something wrong, I will have to do more research on the subject. |
github-actions
bot
added
Workflow
|
This is a disaster, nothing is understood, I better close this and create it again. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
Tests Performed:
This PR has been:
How to Test the Changes:
.unstuckcommand with the name of the character you want to unlock. If it is offline, it will be sent to where the player has the hearthstone established..unstuck barbz2024-05-02.04-54-07.mp4
2024-05-02.04-56-16.mp4
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.