Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db/sai) Added healing options for the Silver Dawn Healer in the Eastern Plaguelands #18852

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fangshun2004
Copy link
Contributor

@fangshun2004 fangshun2004 commented May 1, 2024

When the player has some diseases, the Healer in the Eastern Plaguelands will have a dialog box that can heal the player
I only tried the 3 debuffs in the game and the options show up and there may be more

Clipchamp.mp4

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. .go c 53897 ro .go c 53898
  2. .aura12541 or .aura 3427 or .aura 16449

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label May 1, 2024
@fangshun2004 fangshun2004 changed the title add sai fix(db/sai) Added healing options for the Silver Dawn Healer in the Eastern Plaguelands May 2, 2024
@fangshun2004
Copy link
Contributor Author

OptionBroadcastTextID already uses the id in BroadcastText, so there should be no need to add localized text to the gossip_menu_option_locale

…higher (being able to confirm that neutrality is none)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant