fix(Scripts/IcecrownCitadel): Gunship Cannons generates heat on Cast not on Hit

[qwe900]

Makes the Cannons on Gunship Blizzlike. They generate power (heat) on cast and not on Hit.

Still uses spellscript effect but on cast instead.

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes

SOURCE:

Video proof

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

Go to ICC clear bosses before gunship.
go to gunship horde or alliance and just shoot with button 1 you gain power on cast and not on hit

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[PkllonG]

Tested
Not having a target after PR also heat

[qwe900]

Tested Not having a target after PR also heat

What u mean? Whenever u use the canon button 1, it should heat up the canon

[PkllonG]

Tested Not having a target after PR also heat

What u mean? Whenever u use the canon button 1, it should heat up the canon

yes

[PkllonG]

Tested 6129fb2