Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Scripts/TheEye): prevent Solarian from attacking before becoming invisible #18803

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

balleny
Copy link
Contributor

@balleny balleny commented Apr 24, 2024

boss sometimes attacks before becoming visible.
sometimes doesnt become visible at all - this way it would at least not attack without being visible or engage able

LL153 seems to fire e.g. while there is still a channeled cast going on. the channeled cast delays everything but the channeled cast itself. this results in solarian channeling abilities on the raid before becoming visible again at the end of the whole group triggered in LL150

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. engage fight and wait for split phase
  2. observe if astromancer always becomes visible and engages. this may work sometimes but sometimes it did not.
  3. if astromancer doesnt become visible again, this change should prevent her from attacking at least.
  4. observe if astromancer already channels arcane missles before becoming visible (shouldnt be the case)

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

boss sometimes attacks before becoming visible.
sometimes doesnt become visible at all - that way it would at least not attack without being visible or engage able
@github-actions github-actions bot added CORE Related to the core Script file-cpp Used to trigger the matrix build labels Apr 24, 2024
@kissingers
Copy link

kissingers commented May 19, 2024

Why not change Schedule(23s, this to Schedule(21s, this, So It always appear first before the delay 22s, if both 22s or 23s, might because code operate have diff time, so have a very little change < 0.00000000001% appear same problem.

I meams 06b0250 here no change, and change below 23 to 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core file-cpp Used to trigger the matrix build Script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants