New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aya: Return error messages from netlink #690
Open
dave-tucker
wants to merge
2
commits into
aya-rs:main
Choose a base branch
from
dave-tucker:netlink-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for aya-rs-docs failed.
|
dave-tucker
force-pushed
the
netlink-errors
branch
from
July 26, 2023 19:24
c7cb0bb
to
57e8989
Compare
tamird
reviewed
Jul 26, 2023
This returns error strings from netlink since they are more informative than the raw os error. For example: "Device or Resource Busy" vs. "XDP program already attached". Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
dave-tucker
force-pushed
the
netlink-errors
branch
from
July 26, 2023 22:13
57e8989
to
ad961db
Compare
@dave-tucker, this pull request is now in conflict and requires a rebase. |
The second commit should probably go first? or they should be squashed? |
@dave-tucker, this pull request is now in conflict and requires a rebase. |
@dave-tucker, this pull request is now in conflict and requires a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns error strings from netlink since they are more informative than the raw os error. For example:
"Device or Resource Busy" vs. "XDP program already attached".